Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action for publishing OpenRPC document on new version #2417

Merged
merged 1 commit into from
May 14, 2024

Conversation

Eligioo
Copy link
Member

@Eligioo Eligioo commented May 1, 2024

What's in this pull request?

This PR contains a new Github Action that with every release will publish a new OpenRPC document to the latest release tag.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

.github/workflows/publish_openrpc_document.yml Outdated Show resolved Hide resolved
.github/workflows/publish_openrpc_document.yml Outdated Show resolved Hide resolved
@Eligioo Eligioo force-pushed the stefan/publish-rpc-document branch 2 times, most recently from 94e35d9 to 516864f Compare May 2, 2024 09:40
@Eligioo Eligioo requested a review from jsdanielh May 2, 2024 11:53
@jsdanielh
Copy link
Member

Rebasing branch to merge it

@jsdanielh jsdanielh force-pushed the stefan/publish-rpc-document branch from 516864f to d6fc01f Compare May 2, 2024 13:25
@Eligioo Eligioo force-pushed the stefan/publish-rpc-document branch from d6fc01f to 299dc6a Compare May 3, 2024 09:25
@Eligioo
Copy link
Member Author

Eligioo commented May 3, 2024

@sisou as per the documentation of dtolnay/rust-toolchain, I removed the toolchain input in your NPM Publish Action: Important: the default is to match the @rev as described above. When passing an explicit toolchain as an input instead of @rev, you'll want to use "dtolnay/rust-toolchain@master" as the revision of the action.

EDIT: I wasn't aware that this basically happend for all the GH Actions we have so created a new PR addressing the rest.

.github/workflows/publish_openrpc_document.yml Outdated Show resolved Hide resolved
.github/workflows/publish_openrpc_document.yml Outdated Show resolved Hide resolved
.github/workflows/publish_openrpc_document.yml Outdated Show resolved Hide resolved
Copy link
Member

@hrxi hrxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. :)

@jsdanielh jsdanielh force-pushed the stefan/publish-rpc-document branch from e54fd9b to 567ae57 Compare May 13, 2024 15:43
@Eligioo Eligioo force-pushed the stefan/publish-rpc-document branch from 567ae57 to b7262df Compare May 14, 2024 07:35
@Eligioo Eligioo merged commit b7262df into albatross May 14, 2024
6 checks passed
@Eligioo Eligioo deleted the stefan/publish-rpc-document branch May 14, 2024 07:45
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants