Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify contributions of future round aggregations #1960

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Verify contributions of future round aggregations #1960

merged 8 commits into from
Nov 20, 2023

Conversation

hrxi
Copy link
Member

@hrxi hrxi commented Nov 14, 2023

Fixes #1434.

@hrxi hrxi force-pushed the hrxi/tendermint_verify branch 2 times, most recently from a3ceac6 to dba7ee5 Compare November 15, 2023 16:46
nibhar
nibhar requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@nibhar nibhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Mostly minor comments, except for the selection of the next verification task. I think randomness there is important, as the selection otherwise is based on a value for which the entire network has the same bias.

tendermint/src/tendermint.rs Show resolved Hide resolved
tendermint/src/tendermint.rs Outdated Show resolved Hide resolved
tendermint/src/tendermint.rs Show resolved Hide resolved
validator-network/src/network_impl.rs Outdated Show resolved Hide resolved
validator-network/src/network_impl.rs Outdated Show resolved Hide resolved
validator-network/src/network_impl.rs Show resolved Hide resolved
@hrxi hrxi force-pushed the hrxi/tendermint_verify branch 5 times, most recently from 7401866 to 1e44710 Compare November 18, 2023 20:12
@hrxi
Make #[derive(SerializeContent)] work with lifetime parameters
2ce121f
@hrxi
Fix historic transaction hash collisions
60243a0 
Include block number and network ID in the hash. Also make sure that
they can't clash with normal transactions.

Fixes #1935.
nibhar
nibhar approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@nibhar nibhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrxi hrxi merged commit a7d392c into albatross Nov 20, 2023
6 checks passed
@hrxi hrxi deleted the hrxi/tendermint_verify branch November 20, 2023 17:15
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibhar nibhar nibhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nimiq PoS Mainnet
Development

Successfully merging this pull request may close these issues.

Tendermint: Contributions to future rounds are not verified.
3 participants
@hrxi @nibhar @jsdanielh