-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#546] Support adding new devices directly from Github Action #551
Merged
markgravity
merged 6 commits into
develop
from
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
Aug 7, 2024
Merged
[#546] Support adding new devices directly from Github Action #551
markgravity
merged 6 commits into
develop
from
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgravity
force-pushed
the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
2 times, most recently
from
January 15, 2024 06:46
693a2bd
to
02c0407
Compare
markgravity
force-pushed
the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
7 times, most recently
from
January 22, 2024 08:34
67022d7
to
2cc30c2
Compare
markgravity
force-pushed
the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
7 times, most recently
from
February 26, 2024 08:47
ab5b3cd
to
31ee941
Compare
markgravity
force-pushed
the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
from
March 13, 2024 06:51
31ee941
to
8ca6385
Compare
markgravity
force-pushed
the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
from
March 13, 2024 06:54
8ca6385
to
48e388f
Compare
markgravity
requested review from
suho,
blyscuit,
minhnimble,
nmint8m,
phongvhd93,
vnntsu,
ducbm051291 and
Shayokh144
as code owners
March 13, 2024 06:54
phongvhd93
reviewed
Jul 3, 2024
markgravity
force-pushed
the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
from
July 9, 2024 07:37
c696076
to
78dae3b
Compare
markgravity
changed the base branch from
develop
to
bug/552-correct-logic-for-choosing-the-cicd-service
July 9, 2024 07:37
phongvhd93
approved these changes
Jul 9, 2024
markgravity
force-pushed
the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
from
July 18, 2024 07:46
5dc5db6
to
d40bef7
Compare
markgravity
changed the base branch from
bug/552-correct-logic-for-choosing-the-cicd-service
to
develop
July 22, 2024 06:38
minhnimble
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM!
markgravity
deleted the
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
branch
August 7, 2024 02:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
add_device_profile.yml
workflowaddDevicesGenerateProfiles
Insight 📝
It's because we have a limitation on adding new device so I only test with a fake device information
Proof Of Work 📹