Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#546] Support adding new devices directly from Github Action #551

Conversation

markgravity
Copy link
Contributor

@markgravity markgravity commented Dec 26, 2023

What happened 👀

  • Add add_device_profile.yml workflow
  • Add a new lane addDevicesGenerateProfiles

Insight 📝

It's because we have a limitation on adding new device so I only test with a fake device information

Proof Of Work 📹

CleanShot 2024-02-26 at 15 44 38

@markgravity markgravity force-pushed the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch 2 times, most recently from 693a2bd to 02c0407 Compare January 15, 2024 06:46
@markgravity markgravity force-pushed the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch 7 times, most recently from 67022d7 to 2cc30c2 Compare January 22, 2024 08:34
@markgravity markgravity self-assigned this Jan 22, 2024
@markgravity markgravity force-pushed the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch 7 times, most recently from ab5b3cd to 31ee941 Compare February 26, 2024 08:47
@markgravity markgravity force-pushed the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch from 31ee941 to 8ca6385 Compare March 13, 2024 06:51
@markgravity markgravity force-pushed the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch from 8ca6385 to 48e388f Compare March 13, 2024 06:54
@markgravity markgravity marked this pull request as ready for review March 13, 2024 06:54
.github/project_workflows/add_device_profile.yml Outdated Show resolved Hide resolved
fastlane/Constants/Constant.swift Show resolved Hide resolved
fastlane/Fastfile.swift Show resolved Hide resolved
@markgravity markgravity force-pushed the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch from c696076 to 78dae3b Compare July 9, 2024 07:37
@markgravity markgravity changed the base branch from develop to bug/552-correct-logic-for-choosing-the-cicd-service July 9, 2024 07:37
@markgravity markgravity force-pushed the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch from 5dc5db6 to d40bef7 Compare July 18, 2024 07:46
@markgravity markgravity changed the base branch from bug/552-correct-logic-for-choosing-the-cicd-service to develop July 22, 2024 06:38
Copy link
Member

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

fastlane/Fastfile.swift Show resolved Hide resolved
.github/project_workflows/add_device_profile.yml Outdated Show resolved Hide resolved
@markgravity markgravity added this pull request to the merge queue Aug 7, 2024
Merged via the queue into develop with commit 4c4fc4c Aug 7, 2024
4 checks passed
@markgravity markgravity deleted the feature/546-add-support-to-adding-new-devices-directly-from-github-actions branch August 7, 2024 02:10
@markgravity markgravity added this to the 4.11.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants