Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heroku add-on #55

Merged
merged 7 commits into from
Jul 23, 2021
Merged

Add Heroku add-on #55

merged 7 commits into from
Jul 23, 2021

Conversation

hoangmirs
Copy link
Contributor

@hoangmirs hoangmirs commented Jun 2, 2021

Solve #52

What happened 👀

  • Add Heroku addon
  • Add Heroku with terraform files and directory
  • Update template README and .gitignore

Insight 📝

N/A

Proof Of Work 📹

  • Generate the project

Screen Shot 2564-07-16 at 19 02 18

  • Unit test is passed

Screen Shot 2564-07-16 at 19 03 28

@hoangmirs hoangmirs added this to the 2.0.0 milestone Jun 2, 2021
@hoangmirs hoangmirs self-assigned this Jun 2, 2021
Base automatically changed from feature/add-logrus-addon to develop July 6, 2021 06:51
@gutakk gutakk requested review from gutakk and malparty July 16, 2021 12:03
@gutakk gutakk marked this pull request as ready for review July 16, 2021 12:03
))


def remove_empty_folders():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoangmirs Why do we need this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In remove_heroku_files function, I just remove deploy/heroku, so it still has the empty deploy folder.
I had planned to remove the entire deploy folder, but I think we might have another one in that folder, so I went with this way

@malparty
Copy link
Member

malparty commented Jul 19, 2021

@gutakk @hoangmirs
Just as a cross-check, I'm trying to deploy to Heroku and at the terraform plan cmd, I got a small warning (and a note):

Plan: 4 to add, 0 to change, 0 to destroy.
╷
│ Warning: Value for undeclared variable
│
│ The root module does not declare a variable named "redis_plan" but a value was found in file "terraform.tfvars". If you meant to use this value, add a "variable" block to the
│ configuration.
│
│ To silence these warnings, use TF_VAR_... environment variables to provide certain "global" settings to all configurations in your organization. To reduce the verbosity of
│ these warnings, use the -compact-warnings option.
╵

Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take exactly these actions if you run "terraform apply" now.

It does not seems to be blocker, but I'm still raising it in case it's not showing up in your tests. ;-)

Note that I cannot test the next cmd (terraform apply) as I do not have access to any Heroku organization~

@hoangmirs
Copy link
Contributor Author

@gutakk @hoangmirs
Just as a cross-check, I'm trying to deploy to Heroku and at the terraform plan cmd, I got a small warning (and a note):

It does not seems to be blocker, but I'm still raising it in case it's not showing up in your tests. ;-)

Note that I cannot test the next cmd (terraform apply) as I do not have access to any Heroku organization~

@malparty Thanks for pointing it out. I removed the redundant redis variable in 6bb3e3b
@gutakk Please fetch this branch again if you wanna add more content

@gutakk
Copy link
Contributor

gutakk commented Jul 21, 2021

@gutakk @hoangmirs
Just as a cross-check, I'm trying to deploy to Heroku and at the terraform plan cmd, I got a small warning (and a note):
It does not seems to be blocker, but I'm still raising it in case it's not showing up in your tests. ;-)
Note that I cannot test the next cmd (terraform apply) as I do not have access to any Heroku organization~

@malparty Thanks for pointing it out. I removed the redundant redis variable in 6bb3e3b
@gutakk Please fetch this branch again if you wanna add more content

LGTM

@gutakk gutakk merged commit 0110878 into develop Jul 23, 2021
@gutakk gutakk deleted the feature/add-heroku-addon branch July 23, 2021 06:33
@gutakk gutakk mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants