-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heroku add-on #55
Conversation
77c32bb
to
515af86
Compare
3e8cd87
to
b9ce021
Compare
)) | ||
|
||
|
||
def remove_empty_folders(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoangmirs Why do we need this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In remove_heroku_files
function, I just remove deploy/heroku
, so it still has the empty deploy
folder.
I had planned to remove the entire deploy
folder, but I think we might have another one in that folder, so I went with this way
@gutakk @hoangmirs
It does not seems to be blocker, but I'm still raising it in case it's not showing up in your tests. ;-) Note that I cannot test the next cmd (terraform apply) as I do not have access to any Heroku organization~ |
@malparty Thanks for pointing it out. I removed the redundant redis variable in 6bb3e3b |
LGTM |
Solve #52
What happened 👀
Insight 📝
N/A
Proof Of Work 📹