Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI for application #27

Merged
merged 5 commits into from
Feb 23, 2021
Merged

Setup CI for application #27

merged 5 commits into from
Feb 23, 2021

Conversation

gutakk
Copy link
Contributor

@gutakk gutakk commented Feb 23, 2021 •
edited
Loading

What happened 👀

Resolve #3

  • Add issue templates
  • Add pull request template
  • Add test workflow for application
  • Add go.sum for application
  • Update go.mod

Insight 📝

Linters step in the test workflow requires go.sum otherwise CI will not pass and also update go.mod using make install-dependencies command.

I created the test project repo to test the application CI.
https://github.com/gutakk/test-gin-templates

Proof Of Work 📹

  • Action in the test project repo.
    Screen Shot 2564-02-23 at 11 54 29

@gutakk gutakk added this to the 1.0.0 milestone Feb 23, 2021
@gutakk gutakk self-assigned this Feb 23, 2021
@gutakk gutakk linked an issue Feb 23, 2021 that may be closed by this pull request
Setup CI for application #3
Closed
@gutakk gutakk marked this pull request as ready for review February 23, 2021 04:54
Base automatically changed from feature/template-ci to develop February 23, 2021 10:48
@gutakk gutakk merged commit 42e7354 into develop Feb 23, 2021
@gutakk gutakk deleted the feature/app-ci branch February 23, 2021 11:13
@gutakk gutakk mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierobert olivierobert olivierobert approved these changes

@carryall carryall carryall approved these changes

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@junan junan Awaiting requested review from junan

Assignees

@gutakk gutakk

Labels
type : feature
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Setup CI for application
3 participants
@gutakk @olivierobert @carryall