Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Move database migration right after the database initializing #91

Closed
carryall opened this issue Feb 2, 2023 · 0 comments · Fixed by #94
Closed

Fix: Move database migration right after the database initializing #91

carryall opened this issue Feb 2, 2023 · 0 comments · Fixed by #94
Assignees
@carryall
Labels
type : bug
Milestone
2.1.0

Comments

@carryall
Copy link
Collaborator

carryall commented Feb 2, 2023

Issue

The current template runs the migration in the Dockerfile before the app is built. During development, if there's new code and the application is not deployed yet, running the migration there could produce unexpected errors.

Expected

We should move the database migration right after the database is initialized, just like we did in Varun API project

Steps to reproduce

N/A
@carryall carryall added this to the 2.1.0 milestone Feb 9, 2023
@carryall carryall self-assigned this Feb 9, 2023
carryall added a commit that referenced this issue Feb 16, 2023
@carryall
[gh-91] Move database matter to database folder
973fa05
carryall added a commit that referenced this issue Feb 16, 2023
@carryall
[gh-91] Remove migration run on start
c91172e
@carryall carryall mentioned this issue Feb 16, 2023
Merged
carryall added a commit that referenced this issue Feb 21, 2023
@carryall
[gh-91] Fix test
50450a5
carryall added a commit that referenced this issue Feb 21, 2023
@carryall
[gh-91] Update code blocks in readme
b08976f
carryall added a commit that referenced this issue Mar 7, 2023
@carryall
[gh-91] Add Alex and Best
f7141b1
carryall added a commit that referenced this issue Mar 28, 2023
@carryall
Merge pull request #94 from nimblehq/bug/gh-91-move-db-migration-afte…
256b454 
…r-db-init

Fix: Move database migration right after the database initializing
@carryall carryall mentioned this issue Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carryall carryall

Labels
type : bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

[#91] Fix: Move database migration right after the database initializing nimblehq/gin-templates
1 participant
@carryall