Enhance compile-time and run-time error-trapping of size mismatches for assignment operator #1459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix #1425 .
It puts a bunch of new logic in
sizeAssignAfterRecursing
to catch compile-time and run-time mismatches when a vector or matrix with indexing on the LHS is assigned from another vector or matrix. All the new logic is behind a new nimbleOption so it can be toggled off if it ever causes problems. There is a very real possibility that this will break something in testing as assignment processing is pervasive.