Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: use nkError in sem for import export #357

Merged
merged 1 commit into from
Jun 20, 2022
Merged

compiler: use nkError in sem for import export #357

merged 1 commit into from
Jun 20, 2022

Conversation

saem
Copy link
Collaborator

@saem saem commented Jun 20, 2022

Summary

  • semExportExceptStmt is reworked like semVarOrLet
  • removed deadcode in importer importForwarded
  • more of importer is now nkError aware

semVarOrLet refactor: #316

Notes for Reviewers

  • the cut off point for porting is a little arbitrary (not too big)
  • is the semExportExcept easier to read/reason about?

@saem
compiler: use nkError in sem for import export
d5900e9 
- semExportExceptStmt is reworked like semVarOrLet
- removed deadcode in importer
- more of importer is now nkError aware
@saem saem force-pushed the saem-nkerror-sem-import-export branch from 9f494bb to d5900e9 Compare June 20, 2022 03:40
@saem saem marked this pull request as ready for review June 20, 2022 03:41
@saem
Copy link
Collaborator Author

saem commented Jun 20, 2022

Bors r+

@bors
Copy link
Contributor

bors bot commented Jun 20, 2022

👎 Rejected by PR status

@saem saem closed this Jun 20, 2022
@saem saem reopened this Jun 20, 2022
@saem
Copy link
Collaborator Author

saem commented Jun 20, 2022

Bors r+

@bors
Copy link
Contributor

bors bot commented Jun 20, 2022

Build succeeded:

@bors bors bot merged commit 2bdf28d into nim-works:devel Jun 20, 2022
@haxscramper haxscramper added this to the Sem phase refactoring milestone Nov 21, 2022
@saem saem deleted the saem-nkerror-sem-import-export branch January 22, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Semantic analysis phase refactoring
Development

Successfully merging this pull request may close these issues.
2 participants
@saem @haxscramper