Consistently initialize Exception.name across back-ends
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels more consistent, if some platform compatibility bits come up we can consider those as they arise and revisit. Bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 30, 2022
292: Consistently initialize `Exception.name` across back-ends r=saem a=zerbina Creating an `Exception` without raising it left it's `name` field as nil on the JS and VM back-ends. For the C targets, the name initialization was injected during code-gen. Initializing the `name` field now either happens in `newException` or when raising the exception and thus works the same across all back-ends. Creating an exception without `newException` doesn't set the `name` field on the C back-ends anymore. In addition, when raising an exception on the JS target, the exception's name is not overridden if it's non-nil. This is a breaking change. Co-authored-by: zerbina <[email protected]>
|
Build failed: |
|
The failing cpp test is due to the recent |
Exclude CPP from the test and leave a comment in the test with a comment ( |
|
The failing cpp test should be fixed by #294. I'll rebase, once it's merged |
|
Merge in progress. 🎉 |
|
bors r+ |
Creating an `Exception` without raising it left it's `name` field as nil on the JS and VM back-ends. For the C targets, the name initialization was injected during code-gen. Initializing the `name` field now either happens in `newException` or when raising the exception and thus works the same across all back-ends. Creating an exception without `newException` doesn't set the `name` field on the C back-ends anymore. In addition, when raising an exception on the JS target, the exception's name is not overriden if it's non-nil. This is a breaking change.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating an
Exceptionwithout raising it left it'snamefield as nilon the JS and VM back-ends. For the C targets, the name initialization
was injected during code-gen.
Initializing the
namefield now either happens innewExceptionorwhen raising the exception and thus works the same across all back-ends.
Creating an exception without
newExceptiondoesn't set thenamefield on the C back-ends anymore.
In addition, when raising an exception on the JS target, the exception's
name is not overridden if it's non-nil.
This is a breaking change.
If the exception's name should also be automatically set when not using
newException, I'd propose doing this intransfinstead of during code-gen