Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coroutine example, add walktrough #257

Merged
merged 3 commits into from
Nov 7, 2021

Conversation

ZoomRmc
Copy link
Contributor

@ZoomRmc ZoomRmc commented Nov 7, 2021

I can't stand behind the correctness of my explanation yet, so please review.

I also suspect it's more of a tutorial material, so separating into its own file could be useful.

Copy link
Contributor

@disruptek disruptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy to see this addition to the docs; I've been lazy about it. Thank you!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@disruptek disruptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn near perfect. Nice job.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
examples/coroutine.nim Show resolved Hide resolved
@ZoomRmc
Copy link
Contributor Author

ZoomRmc commented Nov 7, 2021

Thanks a lot for your review, @disruptek, it's very helpful as you accurately point to places where my understanding still lacks.

The explanation of resume and jield could still to be improved further but it's better than nothing.

@disruptek disruptek merged commit c4c34e1 into nim-works:master Nov 7, 2021
@ZoomRmc ZoomRmc deleted the xmpl_coro branch November 7, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants