Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always wrap cps body within try in stmtlist #249

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

alaviss
Copy link
Contributor

@alaviss alaviss commented Oct 18, 2021

Previously this wrapping is exclusive for cps call transformation.
However, as we get more complex transformations, always wrap to ensure
that CPS assumption of the processed node being in the same execution
context with the neighboring nodes is correct.

Included a test where this assumption did not hold.

Previously this wrapping is exclusive for cps call transformation.
However, as we get more complex transformations, always wrap to ensure
that CPS assumption of the processed node being in the same execution
context with the neighboring nodes is correct.

Included a test where this assumption did not hold.
@alaviss alaviss added the release cut a new release upon merge label Oct 18, 2021
@disruptek disruptek enabled auto-merge (squash) October 18, 2021 21:39
@disruptek disruptek merged commit d91c4fd into nim-works:master Oct 18, 2021
@alaviss alaviss deleted the fix-try-body branch October 19, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release cut a new release upon merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants