Skip to content

Conversation

brentp
Copy link

@brentp brentp commented Mar 3, 2019

closes #36

@Araq
Copy link
Member

Araq commented Mar 4, 2019

Well the open returns a bool, why would it raise an exception? This seems to be a breaking change.

@brentp
Copy link
Author

brentp commented Mar 4, 2019

I don't disagree. That's why I asked in #36. What do you suggest?

@Araq
Copy link
Member

Araq commented Mar 4, 2019

Return false for an error?

@brentp
Copy link
Author

brentp commented Mar 4, 2019

that's the current behavior, but there's no to get the cause of the failure.

@Araq
Copy link
Member

Araq commented Mar 8, 2019

Hmm, I dunno. Introduce another constructor then that returns an Error type, maybe. Not everybody cares why open failed, if it failed, that's often all you need to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no error reported on file open

2 participants