Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable unit tests for GitHub Actions #977

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Enable unit tests for GitHub Actions #977

merged 1 commit into from
Jan 18, 2022

Conversation

CyberTailor
Copy link
Contributor

No description provided.

dom96
dom96 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dom96 dom96 merged commit 47a5c6c into nim-lang:master Jan 18, 2022
@bobeff
Copy link
Contributor

bobeff commented Jan 20, 2022

@dom96 @CyberTailor Those unit tests are already enabled when the tester.nim module is being run. It imports tmoduletests.nim which runs the unit tests, so this change is redundant.

@dom96
Copy link
Collaborator

dom96 commented Jan 20, 2022

oh cool. We should revert this then, while we're at it I'd say we should modify tmoduletests to compile and run each module in Nimble's sources, otherwise we'll end up forgetting to add new modules in there. What do you think?

@CyberTailor CyberTailor mentioned this pull request Feb 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberTailor @bobeff @dom96