Fix the doClone procedure to clone a repository as is
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To have the right package checksum when cloning a Git repository, we have to clone it without changing the line endings according to the operating system. Fixes nim-lang#957
dom96
approved these changes
Dec 22, 2021
|
This fix seems to broke the tests exactly in the way of the bug it was intended to fix. 😆 |
When cloning a specific revision we also must disable automatic line endings conversions just like for the `doClone` procedure in the previous commit. Related to nim-lang#957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have the right package checksum when cloning a Git repository, we have to clone it without changing the line endings according to the operating system.
Fixes #957