Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #953 #962

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Fix #953 #962

merged 4 commits into from
Dec 15, 2021

Conversation

ire4ever1190
Copy link
Contributor

@ire4ever1190 ire4ever1190 commented Nov 30, 2021

Fixes issue where nimble didn't search refreshed package list when trying to install a package

Current behavior

image

Behavior after PR

image

Is the way I did it in the PR good or should I instead implement a proc which clears gPackageJson table?

@ire4ever1190 ire4ever1190 marked this pull request as draft November 30, 2021 05:26
@ire4ever1190 ire4ever1190 marked this pull request as ready for review November 30, 2021 06:08
@ringabout
Copy link
Member

ringabout commented Dec 3, 2021

I have seen many Nim users (in my groups) cannot use nimble due to this error. I have been suffering from this error for months.

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one request for changes: let's have clearer identifier names :)

src/nimble.nim Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nimble install doesn't respect newly downloaded packages.json
3 participants