Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks: add tests for PR #912 #914

Merged
merged 1 commit into from
Apr 26, 2021
Merged

tasks: add tests for PR #912 #914

merged 1 commit into from
Apr 26, 2021

Conversation

kraptor
Copy link
Contributor

@kraptor kraptor commented Apr 24, 2021

As requested by @dom96, I added a few to tests to check output of nimble tasks.

The tests cover:

  • If there are no tasks defined
  • If there are tasks with long names
  • If the minimum alignment is respected for very short names

@dom96
Copy link
Collaborator

dom96 commented Apr 25, 2021

Epic, thank you! Can you have a look at the CI, seems the tests are failing.

The tests cover:

- If there are no tasks defined
- If there are tasks with long names
- If the minimum alignment is respected for very short names
@kraptor
Copy link
Contributor Author

kraptor commented Apr 26, 2021

Epic, thank you! Can you have a look at the CI, seems the tests are failing.

There we go :)

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dom96 dom96 merged commit 6d74bde into nim-lang:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants