-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ~ and ^ semver semantic to nimble "requires" #908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Approving, but I'd like to see some docs for this, can you write some explaining what these new operators mean exactly in the readme? :)
Co-authored-by: Dominik Picheta <[email protected]>
Co-authored-by: Dominik Picheta <[email protected]>
Thx for the review :) I will update the readme. |
Sry - after creating some documentation, I made some fixes and refactored a lot of code. However, I think the solution is better than my previous one. Let me know if I should make some additional changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some suggestions for follow up:
- Create tests that verify the version range created for these new intersections, I think that is a much clearer way to test these :)
Might be possible to simplify getNextIncompatibleVersion
, but let's get it merged, we can iterate later. As long as we have tests it's all good :)
Added ~ and ^ semver semantic to nimble "requires"
Check https://devhints.io/semver for semver examples
#907