Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message, make link clickable #905

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

timotheecour
Copy link
Member

before PR: error message contains a dot, which prevents making the link clickable in logs (eg github action logs)

after PR: I remove the dot so the link becomes clickable.

example: https://github.com/nim-lang/Nim/runs/2063531199

 PASS: norm c                                                       ( 6.54 sec)
  PASS: npeg c                                                       (17.42 sec)
  FAIL: numericalnim c
  Test "numericalnim" in category "nimble-packages-2"
  Failure: reInstallFailed
  nimble install --depsOnly -y
    Verifying dependencies for [email protected]
   Installing arraymancer@>= 0.5.0
  Downloading mratsim/Arraymancer using git
    Verifying dependencies for [email protected]
        Info: Dependency on nimblas@>= 0.2.2 already satisfied
    Verifying dependencies for [email protected]
        Info: Dependency on nimlapack@>= 0.1.1 already satisfied
    Verifying dependencies for [email protected]
        Info: Dependency on nimcuda@>= 0.1.4 already satisfied
    Verifying dependencies for [email protected]
        Info: Dependency on nimcl@>= 0.1.3 already satisfied
    Verifying dependencies for [email protected]
        Info: Dependency on opencl@>= 1.0 already satisfied
    Verifying dependencies for [email protected]
        Info: Dependency on clblast@any version already satisfied
    Verifying dependencies for [email protected]
        Info: Dependency on opencl@any version already satisfied
    Verifying dependencies for [email protected]
   Installing stb_image@any version
  Downloading gitlab.com/define-private-public/stb_image-Nim.git using git
  download.nim(93)         getTagsListRemote
  Error: unhandled exception: Unable to query remote tags for gitlab.com/define-private-public/stb_image-Nim.git. Git returned: fatal: unable to access 'gitlab.com/define-private-public/stb_image-Nim.git': The requested URL returned error: 502
   [OSError]
  
  PASS: optionsutils c                                               (10.26 sec)

@narimiran narimiran merged commit 40ce315 into nim-lang:master Mar 9, 2021
@timotheecour timotheecour deleted the pr_improve_errmsg branch March 9, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants