Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zero to hero: nimble is able to function without nim in the path #1269

Merged
merged 6 commits into from
Oct 3, 2024
Merged

zero to hero: nimble is able to function without nim in the path #1269

merged 6 commits into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. when in solver:sat sets the right nim version

    @jmgomez
    jmgomez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e47f4f7 View commit details
    Browse the repository at this point in the history

  2. a more elegant way to retrieve the nim right version 

    Note we may want to have the solvedPackages inside Options but a refactor would be needed for this and first we should remove the support for the `legacy` solver. Everything is build around it ( i.e. the `legacy` solver doesnt have enough information to split the download stage from the build one)
    @jmgomez
    jmgomez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b1efae1 View commit details
    Browse the repository at this point in the history

  3. remove comment

    @jmgomez
    jmgomez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ab1f7a5 View commit details
    Browse the repository at this point in the history

  4. Should use the system nim when --useSystemNim flag is on fixes nim-… 

    …lang#1251.

fixes nim-lang#1251
    @jmgomez
    jmgomez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    640f6d1 View commit details
    Browse the repository at this point in the history

  5. zero to hero: nimble is able to function without nim in the path

    @jmgomez
    jmgomez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    57b7089 View commit details
    Browse the repository at this point in the history

  6. fixes test comp

    @jmgomez
    jmgomez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9a201fe View commit details
    Browse the repository at this point in the history