Remove incorrect package structure warnings. #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planetis-m
commented
Jul 6, 2024
| @@ -176,10 +117,6 @@ proc validatePackageInfo(pkgInfo: PackageInfo, options: Options) = | |||
| if pkgInfo.backend notin ["c", "cc", "objc", "cpp", "js"]: | |||
| raise validationError("'" & pkgInfo.backend & | |||
| "' is an invalid backend.", false) | |||
| if options.action.typ in {actionInstall, actionBuild, actionDevelop, actionCompile, actionCheck}: | |||
There was a problem hiding this comment.
Alternatively we can limit the warning to show for only actionCheck, actionDevelop.
Warning: Symlink already exists in /home/runner/work/nimble/nimble/tests/nimbleDir/bin/y. Replacing.
|
Fails at installing different Nim versions tniminstall.nim seems unrelated. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed https://forum.nim-lang.org/t/11942 and probably in more places before. This PR removes all checks for package structure, these are two but they seem closely tied, regardless everything should work fine even without the warnings.