Make sure that nimble.paths is checked relative to config.nims #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yyoncho
commented
Jan 16, 2023
yyoncho
commented
- this change will allow executing the
- this change will allow executing the
zah
reviewed
Jan 16, 2023
| configFileContentNoLock = fmt""" | ||
| {configFileHeader} | ||
| when system.fileExists("{nimblePathsFileName}"): | ||
| when withDir(thisDir(), system.fileExists("{nimblePathsFileName}")): | ||
| include "{nimblePathsFileName}" | ||
| {sectionEnd} | ||
| """ | ||
| configFileContentWithLock = fmt""" | ||
| {configFileHeader} | ||
| --noNimblePath |
There was a problem hiding this comment.
We've previously agreed that --noNimblePath should be conditional on the presence of a lockfile through a check in the config file itself.
I understand that different snippets are inserted depending on the presence of a lockfile during the execution of nimble setup, but is the snippet updated when the lockfile is created with nimble lock? The approach seems slightly more risky and fragile.
There was a problem hiding this comment.
The reason for using lock file is that you can write the following...
nimble --lock-file=differentLockFileName.lock setup
... and it will still do the right thing. I don't have a strong preference for the approach here - both seem to be good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.