lock: write lock file with final newline #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `nimble lock` wrote the lock file without a final
newline:
$ nimble lock
Info: Generating the lock file...
Verifying dependencies for [email protected]
Success: The lock file is generated.
$ cat nimble.lock
{
"version": 1,
"packages": {}
$ wc -l nimble.lock
3 nimble.lock
Fixes: nim-lang#1056
ee7
force-pushed
the
lockfile-write-with-final-newline
branch
from
46de920
to
1b66c1b
Compare
ee7
changed the title
Araq
reviewed
Jan 8, 2023
ringabout
approved these changes
Jan 31, 2023
ringabout
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
nimble lockwrote the lock file without a final newline:Fixes: #1056