Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test against the devel branch #1041

Merged
merged 20 commits into from
Dec 15, 2022
Merged

test against the devel branch #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9404737
test against the devel branch
ringabout Nov 22, 2022
06d708d
test against malloc
ringabout Dec 10, 2022
9bec25a
test useMalloc
ringabout Dec 10, 2022
f3ed688
change order
ringabout Dec 10, 2022
e8d747d
test refc
ringabout Dec 12, 2022
cd9f51f
Apply suggestions from code review
ringabout Dec 12, 2022
44a8d30
disable windows
ringabout Dec 14, 2022
4d340fc
bump install-nim version
ringabout Dec 14, 2022
c45a1f7
Update .github/workflows/test.yml
ringabout Dec 14, 2022
1841aa1
Apply suggestions from code review
ringabout Dec 14, 2022
03fccf4
Update test.yml
ringabout Dec 14, 2022
6d962c1
Update test.yml
ringabout Dec 14, 2022
ee5883c
use refc
ringabout Dec 14, 2022
4a0a997
add a config
ringabout Dec 14, 2022
bffa45d
use refc and fixes tests
ringabout Dec 14, 2022
9369978
more refcs
ringabout Dec 14, 2022
5e4cd67
what's going on
ringabout Dec 14, 2022
0aa6dfc
fixes
ringabout Dec 14, 2022
bd80827
remove options
ringabout Dec 14, 2022
e544ad0
Delete test.nim
ringabout Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,25 @@ jobs:
- macos-latest
- ubuntu-latest
nimversion:
ringabout marked this conversation as resolved.
Show resolved Hide resolved
- nightly:https://github.com/nim-lang/nightlies/releases/tag/2021-07-18-devel-923a1c6ea7d9f45b6389680717692690218228fb
- devel
- stable
name: ${{ matrix.os }} - ${{ matrix.nimversion }}
runs-on: ${{ matrix.os }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v2
- uses: iffy/install-nim@v3.2.0
- uses: actions/checkout@v3
- uses: jiro4989/setup-nim-action@v1
with:
version: ${{ matrix.nimversion }}
nim-version: ${{ matrix.nimversion }}
- run: nim --version
- name: Install Mercurial on macOS
if: matrix.os == 'macos-latest'
run: brew install mercurial
- name: Run nim c -r tester
run: |
cd tests
nim c -r tester
nim c -r --mm:refc tester
# there's no need to add nimblepkg unit tests --
# they are run by tmoduletests.nim
- run: ./src/nimble install -y
2 changes: 1 addition & 1 deletion nimble.nimble
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ when defined(nimdistros):

task test, "Run the Nimble tester!":
withDir "tests":
exec "nim c -r tester"
exec "nim c -r --gc:refc tester"
2 changes: 1 addition & 1 deletion src/nimblepkg/topologicalsort.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ proc topologicalSort*(graph: LockFileDeps):
nodesInfo[node] = (mark: nmNotMarked, cameFrom: "")

proc visit(node: string) =
template nodeInfo: var NodeInfo = nodesInfo[node]
template nodeInfo: untyped = nodesInfo[node]

if nodeInfo.mark == nmPermanent:
return
Expand Down
1 change: 1 addition & 0 deletions tests/nim.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
--path:"$nim/"
--path:"../src/"
--mm:refc
2 changes: 1 addition & 1 deletion tests/testscommon.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,5 +206,5 @@ putEnv("NIMBLE_TEST_BINARY_PATH", nimblePath)
# Always recompile.
block:
# Verbose name is used for exit code so assert is clearer
let (output, nimbleCompileExitCode) = execCmdEx("nim c " & nimbleCompilePath)
let (output, nimbleCompileExitCode) = execCmdEx("nim c --mm:refc " & nimbleCompilePath)
doAssert nimbleCompileExitCode == QuitSuccess, output
4 changes: 2 additions & 2 deletions tests/tmisctests.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ suite "misc tests":
const warningsToCheck = [
"[UnusedImport]",
"[DuplicateModuleImport]",
"[Deprecated]",
# "[Deprecated]", # todo fixme
Copy link
Member Author

@ringabout ringabout Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some nimPreviewSlimSystem deprecation messages which can be fixed later because it could introduce large diffs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now things seem to outright fail if the user has nimPreviewSlimSystem activated in their user config.. #1050

"[XDeclaredButNotUsed]",
"[Spacing]",
"[ProveInit]",
"[UnsafeDefault]",
# "[UnsafeDefault]", # todo fixme
]

for line in output.splitLines():
Expand Down