Implement task level dependencies #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds test case for setting dependency just for test This needs a special case in implementation since test itself is a special case in nimble task running
Added cases for lock file and deps
Added current task has parameter into `Options`. Made implementation simplier and felt less hacky Starting on lockfile support. Current plan is to add in a field to the lock file which states what task it belongs to
One problem I see with it is if the lock file and nimble file go out of sync, but that seems more like a user error
Tests for more edge cases
Now prints task level requirements in same style as requires
|
Ready for review 👍 |
Araq
reviewed
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #482
Syntax works like so
This is done instead of allowing
requiresat task level since it means a task such astestdoesn't need to be redefined just to add dependencies to it (also is easier to implement).More work still needs to be done, making draft now in case anyone wants to give input while I hack away at it.
What needs to be done (These might work, I just need to write test cases to see if they work)
depsrelated commands (All dependencies should be outputted)