Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow locking nim version in nimble.lock #1017

Merged
merged 14 commits into from
Feb 13, 2023
Merged

Commits on Feb 1, 2023

  1. Fix problem were URL's weren't being resolved

    This caused the lockfiles to ignore certain dependencies
    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2e0e4ef View commit details
    Browse the repository at this point in the history
  2. Tasks are now stored as subgraphs in lock files

    Removes previous hack that needed to read current nimble file state
    
    This changes the lock file structure, but compaitability shouldn't be affected
    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    92bb332 View commit details
    Browse the repository at this point in the history
  3. Add test case for regression

    Using nimlangserver since that was that project I first noticed it with
    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    57f6695 View commit details
    Browse the repository at this point in the history
  4. Task dependency tests are passing again

    Will now investigate other tests
    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    451b63a View commit details
    Browse the repository at this point in the history
  5. Properly merge lock files

    Force yes in tests
    
    Fix tests
    
    Go back to non destructive uninstall for deps
    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    45d5ed5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d1a007d View commit details
    Browse the repository at this point in the history
  7. Check satisisfaction

    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    aae8561 View commit details
    Browse the repository at this point in the history
  8. Remove unused variable

    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    8354713 View commit details
    Browse the repository at this point in the history
  9. Turn off ProveInit for line

    Error says it is due to stdlib but it works a few lines later
    ire4ever1190 authored and yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0f6656e View commit details
    Browse the repository at this point in the history
  10. Allow locking nim version in nimble.lock

    - Fixes nim-lang#953
    
    Allow having nim as locked dependency.
    
    - I will add unit tests once we agree on the approach and once nimble related
    changes in nim are merged (I will link the PR in comment). Ditto for the
    documentation. In order that change to work we have to add nim package in nimble
    packages repo and also add alias compiler -> nim to avoid breaking backward
    compatibility.
    
    Here it is the flow:
    
    ``` bash
    nimble develop nim
    nimble lock
    ```
    
    After that `nimble install` and `nimble build` commands will use the locked
    `nim` version
    yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b1f4e76 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    dc7c3db View commit details
    Browse the repository at this point in the history
  12. Add --use-system-nim setting

    yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b5fa809 View commit details
    Browse the repository at this point in the history
  13. Fix the tests on Windows

    yyoncho committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    5dc23bc View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Configuration menu
    Copy the full SHA
    8e5501b View commit details
    Browse the repository at this point in the history