-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow locking nim version in nimble.lock #1017
Merged
Merged
Commits on Feb 1, 2023
-
Fix problem were URL's weren't being resolved
This caused the lockfiles to ignore certain dependencies
Configuration menu - View commit details
-
Copy full SHA for 2e0e4ef - Browse repository at this point
Copy the full SHA 2e0e4efView commit details -
Tasks are now stored as subgraphs in lock files
Removes previous hack that needed to read current nimble file state This changes the lock file structure, but compaitability shouldn't be affected
Configuration menu - View commit details
-
Copy full SHA for 92bb332 - Browse repository at this point
Copy the full SHA 92bb332View commit details -
Using nimlangserver since that was that project I first noticed it with
Configuration menu - View commit details
-
Copy full SHA for 57f6695 - Browse repository at this point
Copy the full SHA 57f6695View commit details -
Task dependency tests are passing again
Will now investigate other tests
Configuration menu - View commit details
-
Copy full SHA for 451b63a - Browse repository at this point
Copy the full SHA 451b63aView commit details -
Force yes in tests Fix tests Go back to non destructive uninstall for deps
Configuration menu - View commit details
-
Copy full SHA for 45d5ed5 - Browse repository at this point
Copy the full SHA 45d5ed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1a007d - Browse repository at this point
Copy the full SHA d1a007dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aae8561 - Browse repository at this point
Copy the full SHA aae8561View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8354713 - Browse repository at this point
Copy the full SHA 8354713View commit details -
Error says it is due to stdlib but it works a few lines later
Configuration menu - View commit details
-
Copy full SHA for 0f6656e - Browse repository at this point
Copy the full SHA 0f6656eView commit details -
Allow locking nim version in nimble.lock
- Fixes nim-lang#953 Allow having nim as locked dependency. - I will add unit tests once we agree on the approach and once nimble related changes in nim are merged (I will link the PR in comment). Ditto for the documentation. In order that change to work we have to add nim package in nimble packages repo and also add alias compiler -> nim to avoid breaking backward compatibility. Here it is the flow: ``` bash nimble develop nim nimble lock ``` After that `nimble install` and `nimble build` commands will use the locked `nim` version
Configuration menu - View commit details
-
Copy full SHA for b1f4e76 - Browse repository at this point
Copy the full SHA b1f4e76View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc7c3db - Browse repository at this point
Copy the full SHA dc7c3dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5fa809 - Browse repository at this point
Copy the full SHA b5fa809View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dc23bc - Browse repository at this point
Copy the full SHA 5dc23bcView commit details
Commits on Feb 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8e5501b - Browse repository at this point
Copy the full SHA 8e5501bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.