-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Implement 'nimble depsTree' #1012
Conversation
Output JSON? |
I am fine with using json. Something like that: {
"name": "foobar",
"version": ">= 1.0",
"resolvedTo": "1.1",
"depedencies": [{
"name": "foobar-dep",
"version": ">= 1.0",
"resolvedTo": "1.1",
"error": "xx",
"depedencies": [...]
}]
}
we may include also the path to the download dir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Two suggestions:
- Put the code into its own module (let's try to keep nimble.nim clean)
- Include a "version" field in the output JSON so we can make breaking changes to the format.
- Also feel free to support other formats via flags like
--format:GraphML
or similar.
The previous format was a bit more human-friendly and I think it should be the default. Supporting an option like |
Also, @dom96 do you think we should use a shorter name for this (e.g. |
Yeah, I prefer |
I'm fine either way but I think the JSON is readable enough so that it could be the only supported format. |
I am open on suggestion for better/different representation of the tree. Once we agree on the format, I will update the documentation and add tests
The latest version of the code implements the |
Sure, looks good. Can we also put the source code into its own module before merging? |
@dom96 it won't be simply putting the functions into a separate module - that would require restructuring the whole file. |
I can put depsRecursive and printDepsHumanReadable |
I think keeping |
I am open on suggestion for better/different representation of the tree. Once we
agree on the format, I will update the documentation and add tests
Here it is sample output for langserver project