Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can sync ignoring deps not present in lock file even if they are in develop file #1009

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

yyoncho
Copy link
Contributor

@yyoncho yyoncho commented Jul 15, 2022

No description provided.

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good, but can you elaborate the situation this covers?

@yyoncho
Copy link
Contributor Author

yyoncho commented Jul 16, 2022

Changes seem good, but can you elaborate the situation this covers?

In https://github.com/status-im/nim-workspace we are going to have one develop file that is shared across multiple projects which means that you may have projects in develop mode that are not actually dependencies of the current project. This will result in failure when doing nimble sync.

@zah zah merged commit aef6f4f into nim-lang:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants