-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github syntax highlight for Nim extensions (nims, nim.cfg, nimble) #125
Comments
If your issue is that Nim syntax highlighting doesn't work, it's normal. Your changes will take effect with the next Linguist release. There's usually one every month. |
even if it's just a vague indication it's better than nothing |
* should fix nim-lang#125 (hopefully) let me know if I'm mistaken
It will be documented in the new FAQ (cf. github-linguist/linguist#4271). |
* should fix nim-lang#125 (hopefully) let me know if I'm mistaken
* Move core files to 'core' directory. Remove Nimsuggest and Nimble support. * Refactor settings, hotkeys, and nimcheck code. * Fix #110 * Fix file permissions. * fix #118 (#120) * fix #118 * Update core/commands/nimcheck.py Co-Authored-By: timotheecour <[email protected]> * Make command import more correct. * fix #112 (#123) * Split comment grammer into separate file, to support nested multiline comments. Fixes #94 * Update keymaps for new comment definitions. Fixes #94, #97, and #128 * Straighten out TODO matching. * Simplify package settings menu by using native edit_settings command. * Fix comment continuation. * Remove ST2/ST3 distinction. * comment and doc comment completion work (#133) * fix #134 (#135) * fix #125 (#127) * should fix #125 (hopefully) let me know if I'm mistaken * Update Nim.YAML-tmLanguage (#126)
@Varriount I'm trying to figure out how to syntax highlight nim code (inlcuding nimble and nim.cfg) files on github, see github-linguist/linguist#4295 which just got merged and changes Nim section to:
https://github.com/github/linguist/blob/ee29c920f6ecb56750ccb4607b8852dab19082b4/lib/linguist/languages.yml#L3099-L3112
the docs in https://github.com/github/linguist says:
this points to:
Nim: https://github.com/Varriount/NimLime
hence this is why I'm asking you here.
https://github.com/Varriount/NimLime/tree/master/Syntaxes shows
Nim.tmLanguage
Nim_Cfg.tmLanguage
etc
is my PR github-linguist/linguist#4295 wrong (for eg, classify nim.cfg as Nim instead of Nim_Cfg) ?
for eg, for D, there's a single
D.tmLanguage
in https://github.com/textmate/d.tmbundle/blob/master/Syntaxes/even though 2 extensions are shown here:
https://github.com/github/linguist/blob/ee29c920f6ecb56750ccb4607b8852dab19082b4/lib/linguist/languages.yml#L967-L976
but I don't think it would make sense to have nims, nimble, nim.cfg files reported as Nim_Cfg, Nims, Nimble in github language stats, they should just be Nim (as I was trying to do in this PR)
/cc @pchaigno if you have any tips, thanks!
The text was updated successfully, but these errors were encountered: