osproc: fix double close on POSIX #5724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a test. |
Calling close() in some cases issued two close() syscalls to one FD, which is incorrect in multithreaded programs.
|
Test added. It's not ideal (it passed before), but at least shows there is no regression. |
|
Any chance we could get a test that reproduces the issue that this PR fixes? |
|
I can write test for this with dependency on |
|
That should be fine. Make it run on Linux only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling close() in some cases issued two close() syscalls to one FD, which is incorrect in multithreaded programs.