Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless assertion in net.nim #4565

Closed
wants to merge 1 commit into from
Closed

Remove useless assertion in net.nim #4565

wants to merge 1 commit into from

Conversation

Fuyukai
Copy link

@Fuyukai Fuyukai commented Aug 4, 2016

This doesn't seem to be required; it only causes errors.

Fixes #4406

@Araq
Copy link
Member

Araq commented Aug 4, 2016

ping @dom96

@dom96
Copy link
Contributor

dom96 commented Aug 5, 2016

There is a reason that assert is there, fixing that reason isn't trivial: https://github.com/nim-lang/Nim/pull/4565/files#diff-df7c4ae903eab01bc8c4f64f425b48c3R374. IIRC the problem is that the PSK client callback doesn't have access to the underlying SSL context and giving it access is also not so easy.

@dom96
Copy link
Contributor

dom96 commented Aug 13, 2016

Fixed via f44486c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants