Skip to content

fixes #25023; Asyncnet accept leaks socket on SSL error; Regression in devel#25024

Merged
Araq merged 1 commit intonim-lang:develfrom
nitely:fix_25023
Jul 1, 2025
Merged

fixes #25023; Asyncnet accept leaks socket on SSL error; Regression in devel#25024
Araq merged 1 commit intonim-lang:develfrom
nitely:fix_25023

Conversation

@nitely
Copy link
Contributor

@nitely nitely commented Jul 1, 2025

Fixes #25023

Revert the acceptAddr #24896 change. SSL_accept is no longer explicitly called.

@Araq Araq merged commit fbdc9a4 into nim-lang:devel Jul 1, 2025
16 of 18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from fbdc9a4

Hint: mm: orc; opt: speed; options: -d:release
182824 lines; 8.566s; 659.531MiB peakmem

@nitely nitely deleted the fix_25023 branch July 1, 2025 21:07
This was referenced Jul 7, 2025
narimiran pushed a commit that referenced this pull request Jul 8, 2025
…n devel (#25024)

Fixes #25023

Revert the acceptAddr #24896 change. SSL_accept is no longer explicitly
called.

(cherry picked from commit fbdc9a4)
Araq pushed a commit that referenced this pull request Jul 10, 2025
revert #24896

Partially reverting #24896 in #25024 broke CI. So better revert it
completely so the CI is green. I'll investigate the issue later.
narimiran pushed a commit that referenced this pull request Jul 10, 2025
revert #24896

Partially reverting #24896 in #25024 broke CI. So better revert it
completely so the CI is green. I'll investigate the issue later.

(cherry picked from commit 08642ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Asyncnet accept leaks socket on SSL error; Regression in devel

2 participants

Comments