Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the changelog #24213

Merged
merged 2 commits into from
Oct 1, 2024
Merged

update the changelog #24213

merged 2 commits into from
Oct 1, 2024

Conversation

narimiran
Copy link
Member

No description provided.

## Tool changes

- koch now allows bootstrapping with `-d:nimHasLibFFI`, replacing the older option of building the compiler directly w/ the `libffi` nimble package in tow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "in tow" mean?

Copy link
Collaborator

@metagn metagn Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#22322 adds this line, koch now directly clones libffi itself if bootstrapping with -d:nimHasLibFFI instead of the compiler requiring already having it installed as a nimble package. The wording is maybe a bit weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what that means (and nobody noticed it for more than a year that was there :)).

I've pushed a commit to remove it.

@Araq Araq added the merge_when_passes_CI mergeable once green label Oct 1, 2024
@narimiran narimiran merged commit 78983f1 into devel Oct 1, 2024
13 of 16 checks passed
@narimiran narimiran deleted the changelog-update branch October 1, 2024 20:22
@narimiran
Copy link
Member Author

Unrelated CI failures. Merging.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 78983f1

Hint: mm: orc; opt: speed; options: -d:release
174581 lines; 8.144s; 653.805MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants