Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cbuilder for seq type generation #24202

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Sep 30, 2024

addSimpleStruct is just so the compiler doesn't use so much extra computation on analyzing the typ parameter for addStruct, which doesn't change anything for seq types. We could probably still get away with using addStruct instead, or making addStruct accept nil as the typ argument but this would be even more computation.

There were a lot of hidden issues with addStruct being a template & template argument substitution, so most of the behavior is moved into startStruct/finishStruct procs.

This is turning out to be a lot of code for just a couple of changed lines, we might have to split cbuilder into multiple modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant