Skip to content

Fix incorrect inheritance penalty for some objects #24144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Araq merged 3 commits into from
Sep 20, 2024
Merged

Fix incorrect inheritance penalty for some objects #24144

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
584fd7d
edge case
Graveflo Sep 20, 2024
7ee213d
Update compiler/sigmatch.nim
Araq Sep 20, 2024
ab1ce6e
swap terms
Graveflo Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/sigmatch.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,7 @@ proc typeRel(c: var TCandidate, f, aOrig: PType,
reduceToBase(a)
if effectiveArgType.kind == tyObject:
if sameObjectTypes(f, effectiveArgType):
c.inheritancePenalty = 0
c.inheritancePenalty = if tfInheritable in f.flags: 0 else: -1
Copy link
Collaborator

@metagn metagn Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfInheritable isn't always defined for objects with inheritance, but tfFinal is for objects without inheritance. Checking this instead should work.

result = isEqual
# elif tfHasMeta in f.flags: result = recordRel(c, f, a)
elif trIsOutParam notin flags:
Expand Down