make binary not not parse complex expressions on right side
#22078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…ng#22078) * binary `not` only parses simple expressions fixes nim-lang#16324 * switch to primary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16324
This fixes the pragma issue, and is consistent with
notnormally having higher precedence than any infix operator. However the left hand side still parses anything.The issue mentions this:
which no longer parses, because of how binary
notis special cased in type parsing. MeanwhileFoo | Bar not nilbecomes(Foo | Bar) not nilwhich presumably wouldn't be implemented. Maybe in the future we can remove the special parsing and the compiler can handleFoo(not nil)?