fixes #21540; deref block at transf phase to make injectdestructors function properly #21688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
force-pushed
the
pr_deref_block
branch
from
c91e02a
to
c956db5
Compare
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
May 15, 2023
…uctors function properly (nim-lang#21688) * fixes nim-lang#21540; deref block at transf phase to make injectdestructors function properly * add a test case * add one more test * fixes the type of block * transform block
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
May 16, 2023
…uctors function properly (nim-lang#21688) * fixes nim-lang#21540; deref block at transf phase to make injectdestructors function properly * add a test case * add one more test * fixes the type of block * transform block
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…uctors function properly (nim-lang#21688) * fixes nim-lang#21540; deref block at transf phase to make injectdestructors function properly * add a test case * add one more test * fixes the type of block * transform block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21540
If the deref block happens at the codegen phase, injectdestructors cannot know the transformation in advance.