Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #16639 #21017

Merged
merged 1 commit into from
Dec 5, 2022
Merged

fix #16639 #21017

merged 1 commit into from
Dec 5, 2022

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Dec 4, 2022

fixes #16639

@Varriount Varriount requested a review from Araq December 4, 2022 20:45
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Dec 4, 2022
@Araq Araq merged commit e98efdc into nim-lang:devel Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from e98efdc

Hint: mm: orc; opt: speed; options: -d:release
165510 lines; 7.952s; 612.211MiB peakmem

survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
@metagn @survivorm
fix nim-lang#16639 (nim-lang#21017)
e9f4983
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@metagn @capocasa
fix nim-lang#16639 (nim-lang#21017)
ced9ebc
narimiran pushed a commit that referenced this pull request Apr 25, 2023
@metagn @narimiran
fix #16639 (#21017)
46f8ee3 
(cherry picked from commit e98efdc)
narimiran pushed a commit that referenced this pull request May 12, 2023
@metagn @narimiran
fix #16639 (#21017)
746b576 
(cherry picked from commit e98efdc)
narimiran pushed a commit that referenced this pull request May 15, 2023
@metagn @narimiran
fix #16639 (#21017)
bc3e964 
(cherry picked from commit e98efdc)
This was referenced Jun 11, 2023
Closed
Closed
metagn added a commit to metagn/Nim that referenced this pull request Jun 11, 2023
@metagn
more test cases for generic object impl AST
f63a066 
closes nim-lang#9899, closes nim-lang#14708, refs nim-lang#21017
@metagn metagn mentioned this pull request Jun 11, 2023
Merged
Araq pushed a commit that referenced this pull request Jun 11, 2023
@metagn
more test cases for generic object impl AST (#22077)
7b1c448 
closes #9899, closes #14708, refs #21017
jmgomez pushed a commit to jmgomez/Nim that referenced this pull request Jun 11, 2023
@metagn @jmgomez
more test cases for generic object impl AST (nim-lang#22077)
06bf5ed 
closes nim-lang#9899, closes nim-lang#14708, refs nim-lang#21017

temp
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@metagn @bung87
fix nim-lang#16639 (nim-lang#21017)
701aacb
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@metagn @bung87
more test cases for generic object impl AST (nim-lang#22077)
f644e08 
closes nim-lang#9899, closes nim-lang#14708, refs nim-lang#21017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getImpl on types return incorrect tree in when branches
3 participants
@metagn @Araq @Varriount