Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #16264 low(Time) OverflowDefect #20552

Merged
merged 1 commit into from
Oct 29, 2022
Merged

fix #16264 low(Time) OverflowDefect #20552

merged 1 commit into from
Oct 29, 2022

Conversation

bung87
Copy link
Collaborator

@bung87 bung87 commented Oct 12, 2022

…gives OverflowDefect

fix #16264

@Araq
Copy link
Member

Araq commented Oct 12, 2022

So instead you introduced a new regression. Nobody cares about version 0.18 anymore.

@bung87
Copy link
Collaborator Author

bung87 commented Oct 12, 2022 •
edited
Loading

initTime(low(int64), 0) means nothing to me, and it doesn't really work. it's not about 0.18

https://play.nim-lang.org/#ix=4cUC

@bung87 bung87 changed the title fix #16264 regression(0.18.0 => devel): import times; echo low(Time) … fix #16264 low(Time) OverflowDefect Oct 12, 2022
@bung87
Copy link
Collaborator Author

bung87 commented Oct 12, 2022 •
edited
Loading

this existed since v1.4.0 when the times module refactoring.

@bung87
Copy link
Collaborator Author

bung87 commented Oct 28, 2022

@Araq pls merge this!

@Araq Araq merged commit 534c97e into nim-lang:devel Oct 29, 2022
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 534c97e

Hint: mm: orc; opt: speed; options: -d:release
164439 lines; 11.200s; 613.66MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@bung87 @capocasa
fix nim-lang#16264 low(Time) OverflowDefect (nim-lang#20552)
2e91bae 
fix nim-lang#16264 regression(0.18.0 => devel): import times; echo low(Time) gives OverflowDefect
narimiran pushed a commit that referenced this pull request Apr 25, 2023
@bung87 @narimiran
fix #16264 low(Time) OverflowDefect (#20552)
4af3745 
fix #16264 regression(0.18.0 => devel): import times; echo low(Time) gives OverflowDefect

(cherry picked from commit 534c97e)
narimiran pushed a commit that referenced this pull request Apr 25, 2023
@bung87 @narimiran
fix #16264 low(Time) OverflowDefect (#20552)
c07b385 
fix #16264 regression(0.18.0 => devel): import times; echo low(Time) gives OverflowDefect

(cherry picked from commit 534c97e)
narimiran pushed a commit that referenced this pull request Apr 25, 2023
@bung87 @narimiran
fix #16264 low(Time) OverflowDefect (#20552)
b2b226b 
fix #16264 regression(0.18.0 => devel): import times; echo low(Time) gives OverflowDefect

(cherry picked from commit 534c97e)
bung87 added a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@bung87
fix nim-lang#16264 low(Time) OverflowDefect (nim-lang#20552)
7d95ca6 
fix nim-lang#16264 regression(0.18.0 => devel): import times; echo low(Time) gives OverflowDefect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression(0.18.0 => devel): import times; echo low(Time) gives OverflowDefect
2 participants
@bung87 @Araq