Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move formatfloat out of system #20195

Merged
merged 10 commits into from
Aug 24, 2022
Merged

move formatfloat out of system #20195

merged 10 commits into from
Aug 24, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Aug 11, 2022 •
edited
Loading

  • the compiler keeps bootstrapping with -d:nimPreviewSlimSystem.
  • the std/format uses new float algorithm when -d:nimPreviewSlimSystem is enabled, otherwise you can still switch them on/off by nimPreviewFloatRoundtrip.
  • when d:nimPreviewSlimSystem is enabled, you need to import std/formatfloat to use $(float|float32).

ref #19388
ref nim-lang/RFCs#437

@ringabout ringabout added the v2 label Aug 11, 2022
@ringabout ringabout mentioned this pull request Aug 11, 2022
Closed
33 tasks
ringabout
ringabout commented Aug 11, 2022
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@Varriount Varriount requested a review from Araq August 19, 2022 19:54
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Aug 19, 2022
@Araq Araq merged commit b6bfe38 into devel Aug 24, 2022
@Araq Araq deleted the pr_float branch August 24, 2022 11:38
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from b6bfe38

Hint: mm: orc; threads: on; opt: speed; options: -d:release
163875 lines; 16.015s; 840.672MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
move formatfloat out of system (nim-lang#20195)
2d703c9 
* move formatfloat out of system

* fixes doc

* Update changelog.md

* careless

* fixes

* deprecate system/formatfloat

* better handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees

@Araq Araq

Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ringabout @Araq @Varriount