Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults to ORC #19972

Merged
merged 70 commits into from
Sep 23, 2022
Merged

defaults to ORC #19972

merged 70 commits into from
Sep 23, 2022

Conversation

ringabout
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jul 5, 2022

Maybe the default GC for the compiler should be changed in https://github.com/nim-lang/Nim/blob/devel/compiler/nim.cfg instead?

@ringabout
Copy link
Member Author

#19403 should fix the failure of Nim doc CI.

@ringabout
Copy link
Member Author

Here is the draft of "Migration to ORC", I'm adding add issues and solutions of ORC => #20017

@ringabout ringabout mentioned this pull request Jul 25, 2022
1 task
@ringabout ringabout changed the title defaults to Orc defaults to ORC Jul 25, 2022
@ringabout ringabout marked this pull request as ready for review September 22, 2022 02:08
@ringabout ringabout closed this Sep 22, 2022
@ringabout ringabout reopened this Sep 22, 2022
@ringabout ringabout requested a review from Araq September 22, 2022 06:57
@ringabout ringabout added the Requires Araq To Merge PR should only be merged by Araq label Sep 22, 2022
@ringabout
Copy link
Member Author

It is ready for review. So that we can ensure new merged prs are compatible with ORC.

@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 7739e23

Hint: mm: orc; threads: on; opt: speed; options: -d:release
164082 lines; 14.339s; 840.531MiB peakmem

@ringabout
Copy link
Member Author

I will add a changelog and modify corresponding documentation soon.

@MaskRay
Copy link

MaskRay commented Sep 24, 2022

Many bullet points (such as add todo, small, more fixes) in the commit message should have been removed:)

@ringabout
Copy link
Member Author

ringabout commented Sep 25, 2022

The Nim repo always uses squash merge, it is fine not to rebase.

@MaskRay
Copy link

MaskRay commented Sep 25, 2022

My point is about cleaning up the commit message before pushing. Several folks have mentioned this. Force push in a pull request may help (github's review system used to throw away review comments but it gets improved in recent years.)

There are a lot of arguments on the Internet, e.g. https://sourceware.org/gdb/wiki/ContributionChecklist#Detailed_Explanation_of_the_Patch

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
* defaults to Orc

* bootstrap using refc

* use gc

* init orc defines

* unregister orc

* fix gc

* fix commands

* add prepareMutation for orc

* enable deepcopy for orc

* prepareMutation

* more fixes

* some cases

* bug nim-lang#20081

* partial fixes

* partial fixes

* fixes command line

* more fixes

* build Nim with refc

* use gc

* more fixes

* rstore

* orc doesn't support threadpool

* more shallowCopy

* more fixes

* fixes unsafeNew

* workarounds

* small

* more fixes

* fixes some megatest

* tcodegenbugs1 refc

* fxies megatest

* build nimble with refc

* workaround tensordsl tests

* replace shallowCopy with move

* fixes action

* workaround

* add todo

* fixes important packages

* unpublic unregisterArcOrc

* fixes cpp

* enable windows

Co-authored-by: xflywind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants