remove noop option gc:v2
#19810
Merged
remove noop option gc:v2
#19810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
May 24, 2022
| @@ -304,20 +304,10 @@ proc setLengthSeq(seq: PGenericSeq, elemSize, elemAlign, newLen: int): PGenericS | |||
| when not defined(boehmGC) and not defined(nogc) and | |||
| not defined(gcMarkAndSweep) and not defined(gogc) and | |||
| not defined(gcRegions): | |||
| when false: # deadcode: was used by `compileOption("gc", "v2")` | |||
There was a problem hiding this comment.
Looks like an unrelated improvement that I don't understand. Please explain.
There was a problem hiding this comment.
I removed the when false branch which is marked as dead code and used by gc:v2 =>
Line 307 in f561afa
There was a problem hiding this comment.
The GitHub diff cannot show the actual changes reliably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref nim-lang/RFCs#437