Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register callback for marshal in VM #19578

Merged
merged 7 commits into from
Mar 8, 2022
Merged

register callback for marshal in VM #19578

merged 7 commits into from
Mar 8, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout marked this pull request as draft March 2, 2022 03:16
@ringabout ringabout marked this pull request as ready for review March 2, 2022 04:07
Araq
Araq reviewed Mar 2, 2022
View reviewed changes
compiler/vmdef.nim Outdated Show resolved Hide resolved
@ringabout
Copy link
Member Author

ringabout commented Mar 2, 2022 •
edited
Loading

Now it uses two helper procs loadVM and toVM to bypass the limitations of VmArgs -- cannot get the types of return values or generic parameters.

@Araq Araq merged commit 8f9dd5b into nim-lang:devel Mar 8, 2022
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@ringabout @PMunch
register callback for marshal in VM (nim-lang#19578)
c761ad1 
* register callback for marshal in VM

* remove unrelated code

* polish

* more tests

* more tests

* add loadVM and toVM
@ringabout ringabout mentioned this pull request May 11, 2022
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq