allow converting static vars to openArray
#19049
Conversation
When assigning constant output to a seq, and then passing that static seq to other functions that take `openArray`, the compiler may end up producing errors, as it does not know how to convert `static[seq[T]]` to `openArray[T]`. By ignoring the `static` wrapper on the type for the purpose of determining data memory location and length, this gets resolved cleanly. Unfortunately, it is relatively tricky to come up with a minimal example, as there are followup problems from the failing conversion, e.g., this may lead to `internal error: inconsistent environment type`, instead of the relevant `openArrayLoc` error message. (cherry picked from commit 490c422)
|
The CI error in See https://github.com/yglukhov/nimpy/compare/5621afccfc0903e476a440c953daeb5501d99b00..master |
|
The CI error in |
|
We usually don't make PRs to stable branches. PRs are merged into EDIT: I was on outdated |
|
Thanks, and yes, these are indeed cherry-picks from the already-accepted |
When assigning constant output to a seq, and then passing that static
seq to other functions that take
openArray, the compiler may end upproducing errors, as it does not know how to convert
static[seq[T]]to
openArray[T]. By ignoring thestaticwrapper on the type forthe purpose of determining data memory location and length, this gets
resolved cleanly. Unfortunately, it is relatively tricky to come up
with a minimal example, as there are followup problems from the failing
conversion, e.g., this may lead to
internal error: inconsistent environment type, instead of the relevantopenArrayLocerror message.(cherry picked from commit 490c422)