Remove tracking of environment from osenv.nim v2 #18575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pull_18535_osenv_windows
branch
from
63de29f
to
9b4d4fd
Compare
timotheecour
force-pushed
the
pull_18535_osenv_windows
branch
from
9b4d4fd
to
86f54d2
Compare
timotheecour
added
the
Ready For Review
|
Does this code still work? putEnv("key", "value")
assert getEnv("key") == "value"
Because 11 years ago when I wrote the code, it didn't and I had to come up with the |
yes, i just double-checked; if that didn't work nothing would; more importantly, it's covered in the tests, see tosenv.nim which has increased coverage compared to before this PR (c,cpp,js,vm + threads + more testing) EDIT: #18530 (which was merged last week) is also an ingredient that makes this work, by avoiding having to hold on to the strings by using setenv instead of putenv. |
Araq
reviewed
Jul 28, 2021
|
@Araq PTAL |
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* Remove unnecessary environment tracking * try to fix windows * fix delEnv * make putEnv work on windows even with empty values; improve tests: add tests, add js, vm testing * [skip ci] fix changelog Co-authored-by: Caden Haustein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getEnv+ friends gives SIGSEGV or wrong results; osenv should not try to keep track ofenvironment#18533the 1st commit is squashed from #18535 and keeps the author's name
note
code to support empty values on windows (
putEnv("foo", "")) is inspired from facebook/folly@5d8ca09, see also https://github.com/facebook/folly/blob/master/folly/portability/Stdlib.cppthis is the best approach I found after extensive research; it allows having same semantics across backends (c,cpp,js,vm) and os's (osx, linux, windows)
future work
envPairs(via an intermediate seq, like for walkFiles iterator etc)=> tracked in envPairs works in vm, nims #18615
links