fix #17898(alternative to #18149 randomPathName called twice in a row can return the same string on windows) #18412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
commented
Jul 1, 2021
| @@ -4,7 +4,8 @@ internal API for now, API subject to change | |||
|
|
|||
| # xxx move other git utilities here; candidate for stdlib. | |||
|
|
|||
| import std/[os, osproc, strutils, tempfiles] | |||
| import std/[os, osproc, strutils, random] | |||
| from std/tempfiles import genTempPath | |||
There was a problem hiding this comment.
from std/tempfiles {.all.} import genTempPath seems to cause booting issue. So I have to public genTempPath.
ringabout
changed the title
|
instead of requiring client code to pass in a Rand state, how about let's use atomics, as in oids |
|
Passing the rand state is fine... :-/ |
|
I like the var Rand and the inline, I dont know why this API is not in-place, but Ok. |
|
Succeeded by #18729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17898