Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove confusing <//> #17830

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Remove confusing <//> #17830

merged 4 commits into from
Apr 26, 2021

Conversation

ringabout
Copy link
Member

Ref #15307

@timotheecour
Copy link
Member

timotheecour commented Apr 24, 2021 •
edited
Loading

I'm assuming this is possible thanks to csources being updated (refs #16282) to 1.0.11 ?

can these be removed too?

lib/system.nim:889:13:  template `<//>`*(t: untyped): untyped = owned(t)
lib/system.nim:912:13:  template `<//>`*(t: untyped): untyped = t

if for some reason they can't, then how about hiding it behind -d:nimLegacyOwnedOperator

@ringabout
Copy link
Member Author

ringabout commented Apr 24, 2021 •
edited
Loading

I'm assuming this is possible thanks to csources being updated (refs #16282) to 1.0.11 ?

Yeah

if for some reason they can't, then how about hiding it behind -d:nimLegacyOwnedOperator

Ok, let me try to remove it. It should migrate easily even if it's breaking changes. And I guess nobody used it. It looks scary :)

@ringabout
Copy link
Member Author

only fusion/btreetables.nim failed, so I made an associated PR
nim-lang/fusion#90

@timotheecour timotheecour mentioned this pull request Apr 24, 2021
Merged
Araq pushed a commit to nim-lang/fusion that referenced this pull request Apr 25, 2021
@ringabout @ee7
Ref nim-lang/Nim#17830 (#90)
31be851 
* add std/scripting

* thanks for juancarlospaco's suggestion

* Update src/fusion/scripting.nim

Co-authored-by: ee7 <[email protected]>

* Update changelog.md

Co-authored-by: ee7 <[email protected]>

* remove

Co-authored-by: ee7 <[email protected]>
@ringabout ringabout closed this Apr 26, 2021
@ringabout ringabout reopened this Apr 26, 2021
@ringabout ringabout requested a review from Araq April 26, 2021 03:41
@Araq Araq merged commit 68e522e into nim-lang:devel Apr 26, 2021
@timotheecour timotheecour mentioned this pull request Apr 29, 2021
Open
2 tasks
This was referenced Jul 10, 2021
Closed
Closed
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@ringabout @PMunch
Remove confusing <//> (nim-lang#17830)
30c736c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ringabout @timotheecour @Araq