Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove declPragmas from lambdas [backport:1.0] #16966

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Feb 8, 2021

Refs #16967

It makes little sense for any of declPragmas to be in lambdaPragmas. align should also only be for object fields and variables, as in manual

@metagn metagn marked this pull request as draft February 9, 2021 01:40
@metagn metagn marked this pull request as ready for review February 9, 2021 01:47
@metagn
Copy link
Collaborator Author

metagn commented Feb 9, 2021

This does not fix #16967, will open separate PR for that, for now just adding simple test so exportc doesn't compile

@metagn
Copy link
Collaborator Author

metagn commented Feb 9, 2021

CI failure seems unrelated? But is a weird failure nonetheless

@Araq Araq merged commit 49b64e8 into nim-lang:devel Feb 9, 2021
narimiran pushed a commit that referenced this pull request Feb 9, 2021
* Remove declPragmas from lambdas [backport:1.0]

* add test for exportc

* fix test

* fix align, nodecl -> noinit

(cherry picked from commit 49b64e8)
narimiran pushed a commit that referenced this pull request Feb 9, 2021
* Remove declPragmas from lambdas [backport:1.0]

* add test for exportc

* fix test

* fix align, nodecl -> noinit

(cherry picked from commit 49b64e8)
narimiran pushed a commit that referenced this pull request Feb 9, 2021
* Remove declPragmas from lambdas [backport:1.0]

* add test for exportc

* fix test

* fix align, nodecl -> noinit

(cherry picked from commit 49b64e8)
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
* Remove declPragmas from lambdas [backport:1.0]

* add test for exportc

* fix test

* fix align, nodecl -> noinit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants