Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #16703; revert most of #16480; add tests/stdlib/tmimetypes.nim #16711

Merged
merged 1 commit into from
Jan 13, 2021
Merged

fix #16703; revert most of #16480; add tests/stdlib/tmimetypes.nim #16711

merged 1 commit into from
Jan 13, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jan 13, 2021 •
edited
Loading

fix #16703

future work

@timotheecour timotheecour mentioned this pull request Jan 13, 2021
Closed
@dom96
Copy link
Contributor

dom96 commented Jan 13, 2021

wow, this seems to have a very specific use case. Shouldn't have been added to the stdlib in the first place IMO. Just put it into a Nimble package.

@timotheecour timotheecour merged commit fee5fbc into nim-lang:devel Jan 13, 2021
@timotheecour timotheecour deleted the pr_fix_16703_mimesLongest branch January 13, 2021 22:53
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@timotheecour @ardek66
fix nim-lang#16703; revert most of nim-lang#16480; add tests/stdlib/t…
adae0df 
…mimetypes.nim (nim-lang#16711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: compilation 5x slower (33s => 171s for nim_temp c testament)
2 participants
@timotheecour @dom96