Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve uri.parseQuery to never raise an error #16647

Merged
merged 1 commit into from
Jan 12, 2021

Commits on Jan 12, 2021

  1. Improve uri.parseQuery to never raise an error

    In case of malformed query string where there is `=` on the value, handle
    this character as part of the value instead of throwing an error.
    
    The following query string should no longer crash a program:
    
        key=value&key2=x=1
    
    It will be interpreted as [("key", "value"), ("key2", "x=1")]
    
    This is correct according to latest WhatWG's HTML5 specification
    recarding the urlencoded parser:
    https://url.spec.whatwg.org/#concept-urlencoded-parser
    
    Older behavior can be restored using the -d:nimLegacyParseQueryStrict
    flag.
    mildred committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    f9402d1 View commit details
    Browse the repository at this point in the history