macros.quote: document hard to use op; add more useful examples
#16489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
reviewed
Dec 28, 2020
metagn
reviewed
Dec 28, 2020
Closed
timotheecour
force-pushed
the
pr_quote_nnkAccQuoted_example
branch
from
277582e
to
0c8656a
Compare
|
PTAL |
Clyybber
reviewed
Jan 5, 2021
Co-authored-by: Clyybber <[email protected]>
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…m-lang#16489) * macros.quote: document hard to use `op`; add more useful examples * add back doc comment removed in a60305f * address comment * fixup * clarify quoting rules * Update lib/core/macros.nim Co-authored-by: Clyybber <[email protected]> Co-authored-by: Clyybber <[email protected]>
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…m-lang#16489) * macros.quote: document hard to use `op`; add more useful examples * add back doc comment removed in a60305f * address comment * fixup * clarify quoting rules * Update lib/core/macros.nim Co-authored-by: Clyybber <[email protected]> Co-authored-by: Clyybber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11722 (or a revived version addressing #11722 (comment)) should still be done but in the meantime this improves existing
macros.quoteby:=destroy)opwhich I doubt no-one ever used (?) because it was under-documented (doc comment was removed in a60305f; I'm adding it back here) and had no example